Homec4science

Fix `differential.getdiff`, etc., for diffs with no Arcanist Project

Authored by epriestley <git@epriestley.com> on Sep 24 2013, 19:48.

Description

Fix differential.getdiff, etc., for diffs with no Arcanist Project

Summary:
getArcanistProjectName() has some logic which gets messy with the self::ATTACHABLE mechanism. This makes differential.getdiff and similar Conduit methods throw an exception when querying a diff which doesn't have a project. See http://pastebin.com/Czzrd0Jz.

Instead, unconditionally attach a project (possibly null) when loading diffs if they need projects.

Test Plan: Ran differential.getdiff against a arc diff --raw diff with no project, got a result instead of an exception.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, sttwister

Differential Revision: https://secure.phabricator.com/D7101

Details

Committed
epriestley <git@epriestley.com>Sep 24 2013, 19:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0d77a7f39f47: ObjectHeader Status icons
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH119c2b8cecf6: Fix `differential.getdiff`, etc., for diffs with no Arcanist Project (authored by epriestley <git@epriestley.com>).Sep 24 2013, 19:48