Homec4science

Files - kill tabs

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 15 2011, 07:37.

Description

Files - kill tabs

Summary:
kill tabs for Files application. Technique is the "filter list" on the left
hand side, with separation for "Files" versus "Image Macros". UI quirks
include:

  • the page title does not change for the 3 files filters while it does change

for each of the two image macro filters.

  • standalone "file" pages do not have the filter view
  • you can visit /file/upload/ standalone and it doesn't have the pretty filter

list on it

Please do give direction on these quirks if you like. :)

This change also neuters the ?author= functionality for files. The code is
written such that it can easily be brought back.

Test Plan: clicked around on the filters, liked what I saw. uploaded files
fancy-like and basic-like and it worked! made image macros and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, btrahan, epriestley

Maniphest Tasks: T631

Differential Revision: 1219

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Dec 15 2011, 23:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0e7049e8aafc: Countdown - kill tabs
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH128b7584da02: Files - kill tabs (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 15 2011, 23:32