Homec4science

Have EditEngine API methods provide the correct application to Conduit

Authored by epriestley <git@epriestley.com> on Nov 16 2015, 18:24.

Description

Have EditEngine API methods provide the correct application to Conduit

Summary:
Fixes T9799. Currently, if you can't see an application like Paste, we fatal when trying to generate a result for conduit.query, because the new EditEngine-based paste.edit method doesn't "know" that it's a "Paste" method.

Straighten this out, and use policies and queries a little more correctly/consistently.

Test Plan:

  • Called conduit.query as a user who does not have permission to use Paste.
  • Before change: fatal.
  • After change: results, excluding "paste.*" methods.

Reviewers: chad

Reviewed By: chad

Subscribers: cburroughs

Maniphest Tasks: T9799

Differential Revision: https://secure.phabricator.com/D14492

Details

Committed
epriestley <git@epriestley.com>Nov 16 2015, 19:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5963c4c9e06d: Fix history link in Diffusion non-root browse views
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH12dd9ec3ff34: Have EditEngine API methods provide the correct application to Conduit (authored by epriestley <git@epriestley.com>).Nov 16 2015, 19:02