Homec4science

Begin separating inline comment scaffolding from other renderers

Authored by epriestley <git@epriestley.com> on Mar 6 2015, 14:44.

Description

Begin separating inline comment scaffolding from other renderers

Summary:
Ref T2009. Inline comments have "scaffolding", which is basically some empty table cells/rows around them to get the layout correct.

The scaffolding depends on the renderer, since the cells are different for side-by-side vs unified diffs.

This is currently duplicated all over the place:

  • Edit view has 1up/2up.
  • Detail view has 1up/2up.
  • 1up renderer has 1up.
  • 2up renderer has four separate copies of the 2up logic.

These all have subtle differences, which are mostly bugs. Start making the scaffolding more composable so we can get rid of that mess.

Test Plan: Added, edited, and removed inline comments on unified and side-by-side diffs.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D11997

Details

Committed
epriestley <git@epriestley.com>Mar 7 2015, 00:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1088d34e58eb: Rename inline comment views to "PHUIDiff" and give them a base class
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1352be827e12: Begin separating inline comment scaffolding from other renderers (authored by epriestley <git@epriestley.com>).Mar 7 2015, 00:00