Homec4science

Fix table layout bug for inline comments

Authored by Nick Harper <nharper@fb.com> on Jan 6 2012, 23:46.

Description

Fix table layout bug for inline comments

Summary:
The filename header for inline comments used to span 2 columns - the line number
and the comment. With the addition of a column for the diff (to link to inline
comments on previous diffs), the filename header should now span 3 columns
instead of just the line number and diff, leaving the comment squished to the
right.

Test Plan:
Opened a differential revision with an inline comment from a previous diff, and
saw that the filename header continued across the comment. Also checked an
inline comment on a current diff, and saw that it looks fine.

Reviewers: epriestley, btrahan, jungejason

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1340

Details

Committed
Nick Harper <nharper@fb.com>Jan 6 2012, 23:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5e486db59d65: Enable Table of Contents in Phriction
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH13d930b232dc: Fix table layout bug for inline comments (authored by Nick Harper <nharper@fb.com>).Jan 6 2012, 23:55