Homec4science

Use a join instead of an awkward, weird query in PhabricatorAuditListController

Authored by epriestley <git@epriestley.com> on Mar 7 2012, 04:47.

Description

Use a join instead of an awkward, weird query in PhabricatorAuditListController

Summary:

  • Use a join to effect this query.
  • Fixes a bug where packages with no commits would raise an exception because of the awkward query construction.
  • Fixes a bug on audit views.

Test Plan:

  • Viewed a package with no commits.
  • Altered audit filters.

Reviewers: btrahan, 20after4

Reviewed By: 20after4

CC: aran, epriestley

Maniphest Tasks: T904

Differential Revision: https://secure.phabricator.com/D1801

Details

Committed
epriestley <git@epriestley.com>Mar 7 2012, 04:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1706212e24d0: Minor, ensure auditors is an array.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH140927926d20: Use a join instead of an awkward, weird query in PhabricatorAuditListController (authored by epriestley <git@epriestley.com>).Mar 7 2012, 04:47