Homec4science

Fix a Maniphest issue where multiple saved copies of a query break the menu

Authored by epriestley <git@epriestley.com> on Dec 21 2012, 14:42.

Description

Fix a Maniphest issue where multiple saved copies of a query break the menu

Summary: Fixes T2210. Recently, we require unique keys on menu items, but it's currently possible in Maniphest to save the same custom query under multiple names. Avoid exploding in this case (we'll hide the duplicates). This isn't a great fix, but makes Maniphest usable again.

Test Plan: Saved the same query twice, laoded page, got exception, applied patch, loaded page, saw duplicate query stripped.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2210

Differential Revision: https://secure.phabricator.com/D4247

Details

Committed
epriestley <git@epriestley.com>Dec 21 2012, 14:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9358b08b4604: Use "Diff <id>" instead of "D<id>" in changeset view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH141318fd01f4: Fix a Maniphest issue where multiple saved copies of a query break the menu (authored by epriestley <git@epriestley.com>).Dec 21 2012, 14:42