Homec4science

Skip anon functions in symbol generation script

Authored by Eric Stern <eric@ericstern.com> on Jan 24 2014, 02:01.

Description

Skip anon functions in symbol generation script

Summary:
Filters closures out of symbol generator script, per @epriestley's
comment in T4334

Test Plan:
Before:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php
  function php  /closure.php
 d function php 10 /closure.php
  function php  /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

After:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php
 d function php 10 /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

eric@eric-dev ~/phabricator/scripts/symbols: cat closure.php

<?php

class a {
  function b() {
    $c = function() { return 1; };
    $c();
  }
}

function d() {
  return 2;
}
$e = function() {
  return 3;
};

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: epriestley, Korvin, aran

Differential Revision: https://secure.phabricator.com/D8054

Details

Committed
epriestley <git@epriestley.com>Jan 24 2014, 02:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfebc494737be: Actually check CSRF on Password and LDAP forms
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH14f070a0af79: Skip anon functions in symbol generation script (authored by Eric Stern <eric@ericstern.com>).Jan 24 2014, 02:01