Homec4science

Give Conduit params/return/errors protected visibility

Authored by epriestley <git@epriestley.com> on Apr 13 2015, 00:59.

Description

Give Conduit params/return/errors protected visibility

Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a getX() around the defineX() methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:

  • Ran arc unit --everything.
  • Called conduit.query.
  • Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380

Details

Committed
epriestley <git@epriestley.com>Apr 13 2015, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6e4f508bebdb: Provide "builtin" high-level result orders
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH156b156e77b6: Give Conduit params/return/errors protected visibility (authored by epriestley <git@epriestley.com>).Apr 13 2015, 20:58