Homec4science

[differential] Prevent un-closeable overlay

Authored by bhiller <bhiller@facebook.com> on Apr 20 2011, 10:58.

Description

[differential] Prevent un-closeable overlay

Summary:
Currently if I go to leave an inline comment and then decide
against it and hit <tab>-<enter>, the inline comment edit dialog closes
but the overlay doesn't disappear due to a JS error around trying to
access the markup property of null. This fixes that by setting the
payload to an array with empty markup so that the JS works and the
overlay disappears.

Test Plan:
clicked on the line number column, then pressed ok and
confirmed the dialog closed, the overlay disappeared and there were no
JS errors. also tested that for clicking the reply link and when editing
an existing inline comment.

Reviewed By: aran
Reviewers: epriestley, aran
CC: aran, bh
Revert Plan:
OK

Differential Revision: 154

Details

Committed
bhiller <bhiller@facebook.com>Apr 21 2011, 03:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa6c770217dc8: Fixed whitespace options in Differential.
Branches
Unknown
Tags
Unknown

Event Timeline

bhiller <bhiller@facebook.com> committed rPH15e71e9bf4c3: [differential] Prevent un-closeable overlay (authored by bhiller <bhiller@facebook.com>).Apr 21 2011, 03:50