Homec4science

Possible fix for JX.History spookiness?

Authored by epriestley <git@epriestley.com> on Apr 21 2015, 01:41.

Description

Possible fix for JX.History spookiness?

Summary: Ref T7573. I only got this reproducing like 10% of the time in Firefox but I can't reproduce it anymore after this change.

Test Plan:

  • Added some logging.
  • Saw Firefox handing us nonsense state values (?)
  • Read the Firefox documentation?
  • Maybe state is expected to be an object? This shouldn't matter?
  • I don't really know?

iiam

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7573

Differential Revision: https://secure.phabricator.com/D12485

Details

Committed
epriestley <git@epriestley.com>Apr 21 2015, 01:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4d5badeec071: Quicksand - provide some plumbing for fancier updates
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1602858b2662: Possible fix for JX.History spookiness? (authored by epriestley <git@epriestley.com>).Apr 21 2015, 01:41