Homec4science

Lift common code for transaction-based reply handlers into parent class

Authored by epriestley <git@epriestley.com> on Apr 1 2015, 17:39.

Description

Lift common code for transaction-based reply handlers into parent class

Summary:
Ref T7199. Essentially all of the reply handlers now apply transactions to something which implements PhabricatorApplicationTransactionInterface.

We can share code between them by lifting this stuff into a superclass.

First, convert paste. Also rename PasteMockMailReceiver to PasteMailReceiver (this got mis-copied from Pholio at some point, I think).

Test Plan: Used bin/mail receive-test to send comments + !unsubscribe to pastes.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7199

Differential Revision: https://secure.phabricator.com/D12236

Details

Committed
epriestley <git@epriestley.com>Apr 1 2015, 17:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHafd86a042057: Improve rules for embedding files received via email
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH161f936871b8: Lift common code for transaction-based reply handlers into parent class (authored by epriestley <git@epriestley.com>).Apr 1 2015, 17:39