Homec4science

Refine available filters and defaults for relationship selection

Authored by epriestley <git@epriestley.com> on Jun 30 2016, 19:51.

Description

Refine available filters and defaults for relationship selection

Summary:
Ref T4788. Fixes T10703.

In the longer term I want to put this on top of ApplicationSearch, but that's somewhat complex and we're at a fairly good point to pause this feature for feedback.

Inch toward that instead: provide more appropriate filters and defaults without rebuilding the underlying engine. Specifically:

  • No "assigned" for commits (barely makes sense).
  • No "assigned" for mocks (does not make sense).
  • Default to "open" for parent tasks, subtasks, close as duplicate, and merge into.

Also, add a key to the search_document table to improve the performance of the "all open stuff of type X" query. "All Open Tasks" is about 100x faster on my machine with this key.

Test Plan:

  • Clicked all object relationships, saw more sensible filters and defaults.
  • Saw "open" query about 100x faster locally (300ms to 3ms).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788, T10703

Differential Revision: https://secure.phabricator.com/D16202

Details

Committed
epriestley <git@epriestley.com>Jun 30 2016, 20:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7574f8dcf51a: When all actions in a submenu are disabled, disable the submenu header
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH163f2c4262a2: Refine available filters and defaults for relationship selection (authored by epriestley <git@epriestley.com>).Jun 30 2016, 20:51