Homec4science

Improve handle semantics with HandlePool / HandleList

Authored by epriestley <git@epriestley.com> on Mar 30 2015, 03:22.

Description

Improve handle semantics with HandlePool / HandleList

Summary:
Ref T7689, which discusses some of the motivation here. Briefly, these methods are awkward:

  • Controller->loadHandles()
  • Controller->loadViewerHandles()
  • Controller->renderHandlesForPHIDs()

This moves us toward better semantics, less awkwardness, and a more reasonable attack on T7688 which won't double-fetch a bunch of data.

Test Plan:

  • Added unit tests.
  • Converted one controller to the new stuff.
    • Viewed countdown lists, saw handles render.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12202

Details

Committed
epriestley <git@epriestley.com>Mar 31 2015, 14:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3f738e193567: Conpherence - fix see more link
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1752be630c28: Improve handle semantics with HandlePool / HandleList (authored by epriestley <git@epriestley.com>).Mar 31 2015, 14:48