Homec4science

Remove `break` from hunk migration

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 15 2015, 00:32.

Description

Remove break from hunk migration

Summary: This break statement causes ./bin/hunks migrate to only migrate one-hunk-at-a-time, which is unnecessary and slightly misleading. Instead, allow the script to migrate all legacy hunks to modern storage. In particular, this means that we can recommend that installs run this command sometime before D13222 is landed.

Test Plan: It's a pain to setup the data necessary to test this, but this is identical to the change that I made on our production install when I migrated our hunk storage.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13288

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 15 2015, 00:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH32f4c962fc6e: Remove "@stable" annotations
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH175799fab99b: Remove `break` from hunk migration (authored by Joshua Spence <josh@joshuaspence.com>).Jun 15 2015, 00:32