Homec4science

Fix {Fnnn} rule in Remarkup

Authored by epriestley <git@epriestley.com> on Feb 14 2013, 22:09.

Description

Fix {Fnnn} rule in Remarkup

Summary:
Remarkup rule callbacks now get SafeHTML matches instead of string matches. If they call:

$some_lisk_dao->load($matches[1]);

..as is the case with the {F123} rule, we reject the SafeHTML as an invalid ID and return null.

Allow load() to string convert any object (which will either succeed or fatal in an obviously-broken way).

(Long ago we threw instead of returning null here, but it meant we had to do a lot of redundant checks.)

Test Plan: {F123} shows an image again. {C1} embeds a countdown.

Reviewers: vrana, chad

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D4961

Details

Committed
epriestley <git@epriestley.com>Feb 14 2013, 22:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfb32a64d8437: Convert Projects to use ObjectItemList
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH176ee9a889df: Fix {Fnnn} rule in Remarkup (authored by epriestley <git@epriestley.com>).Feb 14 2013, 22:09