Homec4science

Treat keyCode 10 as "return" in JX.Event

Authored by epriestley <git@epriestley.com> on Mar 19 2013, 18:57.

Description

Treat keyCode 10 as "return" in JX.Event

Summary: Fixes T2753. Return is sent as either 10 or 13, depending on browser and OS. See, e.g. this Chromium issue.

Test Plan: @cystorm confirmed this patch fixes the issue on his system.

Reviewers: btrahan, codeblock

Reviewed By: codeblock

CC: cystorm, aran

Maniphest Tasks: T2753

Differential Revision: https://secure.phabricator.com/D5381

Details

Committed
epriestley <git@epriestley.com>Mar 19 2013, 18:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd43bcdc1eece: Adding pro tips to Differential commit message
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH17b9ac41f118: Treat keyCode 10 as "return" in JX.Event (authored by epriestley <git@epriestley.com>).Mar 19 2013, 18:57