Homec4science

Schedule monthly events on the 29th, 30th or 31st relative to the end of the…

Authored by epriestley <git@epriestley.com> on Oct 31 2016, 19:14.

Description

Schedule monthly events on the 29th, 30th or 31st relative to the end of the month

Summary:
Ref T11326. If you scheudle a monthly event on the 31st, the default behavior of RRULE means that it only occurs in months with 31 days.

This is actually how Google Calendar and Calendar.app both work: if you schedule a monthly event on the 31st, you get about six events per year.

This seems real confusing and bad to me?

Instead, if the user schedules a monthly event on the 29th, 30th or 31st, pretend they scheduled it on the "last day of the month" or "second-to-last day of the month" or similar, so they always get 12 events per year.

This could be slightly confusing too, but seems way less weird than not getting an event every month.

Test Plan: Scheduled events on the 31st of October, saw them occur in November too after the patch.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11326

Differential Revision: https://secure.phabricator.com/D16775

Details

Committed
epriestley <git@epriestley.com>Oct 31 2016, 22:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPH850fcf020758: Move event recurrence controls to a separate page on the workflow
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH182611ef7e57: Schedule monthly events on the 29th, 30th or 31st relative to the end of the… (authored by epriestley <git@epriestley.com>).Oct 31 2016, 22:13