Homec4science

Support symbol linking in Remarkup code blocks

Authored by Alan Huang <alanh@fb.com> on Aug 14 2012, 23:03.

Description

Support symbol linking in Remarkup code blocks

Summary:
Trigger the crossreference behavior on code blocks. Limited to
Differential, where we know what the project is, but includes regular
comments, inline comments, and previews of both.

(Hopefully event handlers on deleted elements also get deleted, so we
don't leak memory? Also, caching is a problem, and I didn't find a way
to mark existing cache entries as stale, like
DifferentialChangesetParser::CACHE_VERSION...)

Test Plan:
Load Differential revision, make lots of comments, click on
things.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1602

Differential Revision: https://secure.phabricator.com/D3283

Details

Committed
Alan Huang <alanh@fb.com>Aug 14 2012, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0f076779b254: Merge pull request #180 from r4nt/differential-unified-comments
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPH1855ed4bee40: Support symbol linking in Remarkup code blocks (authored by Alan Huang <alanh@fb.com>).Aug 14 2012, 23:03