Homec4science

Make Differential timeline aware of ghostly inlines

Authored by epriestley <git@epriestley.com> on Apr 22 2015, 00:32.

Description

Make Differential timeline aware of ghostly inlines

Summary:
Ref T7447. Ref T7870.

When a ghostly inline appears on the page, the timeline isn't currently aware that it's present, so it links elsewhere.

Instead, apply adjustments before rendering the timeline.

Ref T5030. This makes the behaviors in T5030 irrelevant most of the time.

Test Plan:
Before:

{F378106}

After:

  • Inlines visible on page are linked directly.
  • Inlines which we can't port (e.g., on files not present on current page) are still linked off-page.
  • Used "Show Older" to page through and verify consistent rendering.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, epriestley

Maniphest Tasks: T5030, T7870, T7447

Differential Revision: https://secure.phabricator.com/D12497

Details

Committed
epriestley <git@epriestley.com>Apr 22 2015, 00:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd8bd3efa2c69: Simplify timeline rendering on Differential revisions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1858d2aa6679: Make Differential timeline aware of ghostly inlines (authored by epriestley <git@epriestley.com>).Apr 22 2015, 00:32