Homec4science

Allow broader HTTP access to public repositories, respect nonstandard…

Authored by epriestley <git@epriestley.com> on May 25 2016, 17:07.

Description

Allow broader HTTP access to public repositories, respect nonstandard Phabricator HTTP port when generating repository URIs

Summary:
Fixes T11030. Fixes T11032.

  • Allow HTTP access to "Public" repositories even if diffusion.allow-http-auth is disabled.
  • If you run Phabricator on an unusual port (???) use that port as the default when generating HTTP URIs.

Test Plan:

  • Faked phabricator.base-uri to an unusual port, saw repository HTTP URI generate with an unusual port.
  • Disabled diffusion.allow-http-auth, confirmed that toggling view policy between "public" and "users" activated or deactivated HTTP clone URI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11030, T11032

Differential Revision: https://secure.phabricator.com/D15973

Details

Committed
epriestley <git@epriestley.com>May 25 2016, 18:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd1eed54d85bc: Fix expansion of projects into lists of user PHIDs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH189600e4116e: Allow broader HTTP access to public repositories, respect nonstandard… (authored by epriestley <git@epriestley.com>).May 25 2016, 18:07