Homec4science

Add a setup warning about missing 'fileinfo'

Authored by epriestley <git@epriestley.com> on May 17 2013, 19:00.

Description

Add a setup warning about missing 'fileinfo'

Summary:
See https://github.com/facebook/phabricator/issues/320. We have a soft dependency on 'fileinfo', which we try to recover from (with file) but won't be able to on Windows and apparently FreeBSD systems. Since users can ignore setup checks anyway now, just raise a warning during install.

I believe almost all installs should have this extension, it has been part of the core for a long time.

Test Plan: Faked setup failure, looked at warning. "Solved" setup failure, saw it go away.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5952

Details

Committed
epriestley <git@epriestley.com>May 17 2013, 19:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9e5410e6a213: Rename `bin/files metadata` to `bin/files rebuild` and let it rebuild MIME…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1898a540d805: Add a setup warning about missing 'fileinfo' (authored by epriestley <git@epriestley.com>).May 17 2013, 19:00