Homec4science

Make TabGroups a standalone UI element

Authored by epriestley <git@epriestley.com> on Jul 1 2016, 00:57.

Description

Make TabGroups a standalone UI element

Summary:
Ref T10628. Currently, tabs are part of ObjectBoxes. However, the code is a bit of a mess and I want to use them in some other contexts, notably the "prose diff" dialog to show "old raw, new raw, diff".

Pull them out, and update Files to use the new stuff. My plan is:

  • Update all callsites to this stuff.
  • Remove the builtin-in ObjectBox integration to simplify ObjectBox a bit.
  • Move forward with T10628.

This is pretty straightforward. A couple of the sigils are a little weird, but I'll update the JS later. For now, the same JS can drive both old and new tabs.

Test Plan: Viewed files, everything was unchanged.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16205

Details

Committed
epriestley <git@epriestley.com>Jul 1 2016, 03:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH01862b8f23ac: Detect the MIME type of large files by examining the first chunk
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH189910d6157c: Make TabGroups a standalone UI element (authored by epriestley <git@epriestley.com>).Jul 1 2016, 03:49