Homec4science

Add "requestedObjectPHID" to ReleephRequest

Authored by epriestley <git@epriestley.com> on Apr 20 2014, 20:55.

Description

Add "requestedObjectPHID" to ReleephRequest

Summary:
Ref T3551. Currently, ReleephRequests don't have a direct concept of the object being requested. You can request D123, but that is just a convenient way to write rXyyyy.

When the UI wants to display information about a revision, it deduces it by examining the commit.

This is primarily an attack on T3551, so we don't need to load <commit -> edge -> revision> (in an ad-hoc way) to get revisions. Instead, when you request a revision we keep track of it and can load it directly later.

Later, this will let us do more things: for example, if you request a branch, we can automatically update the commits (as GitHub does), etc. (Repository branches will need PHIDs first, of course.)

This adds and populates the column but doesn't use it yet. The second part of the migration could safely be run while Phabricator is up, although even for Facebook this table is probably quite small.

Test Plan:

  • Ran migration.
  • Verified existing requests associated sensibly.
  • Created a new commit request.
  • Created a new revision request.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3551

Differential Revision: https://secure.phabricator.com/D8822

Details

Committed
epriestley <git@epriestley.com>Apr 20 2014, 20:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa588955bf79e: Remove loadPhabricatorRepository from ReleephProject
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1a3ac099751b: Add "requestedObjectPHID" to ReleephRequest (authored by epriestley <git@epriestley.com>).Apr 20 2014, 20:55