Homec4science

Pick context windows for inlines in a slightly smarter way

Authored by epriestley <git@epriestley.com> on May 5 2016, 19:53.

Description

Pick context windows for inlines in a slightly smarter way

Summary:
Ref T10694. This mostly prevents us from having a degenerate case if someone leaves a 200-line inline.

  • For one-line inlines, show 1 line of context above and below (3 lines total).
  • For 3+ line inlines, show just the inline.
  • For 7+ line inlines, show only the first part.

Test Plan: Made a bunch of weird long/short/different-sized comments, saw reasonble-appearing context in text and HTML mail output.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10694

Differential Revision: https://secure.phabricator.com/D15853

Details

Committed
epriestley <git@epriestley.com>May 5 2016, 20:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH94c7bb605c35: Highlight inline diff context in HTML mail
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1baef494c1b7: Pick context windows for inlines in a slightly smarter way (authored by epriestley <git@epriestley.com>).May 5 2016, 20:15