Homec4science

Fix infinite loop in renderAccessDenied()

Authored by epriestley <git@epriestley.com> on Jun 30 2015, 20:42.

Description

Fix infinite loop in renderAccessDenied()

Summary:
Fixes T8727. When I added setParentQuery(), I increased the cache hit rate but also accidentally propagated policy exception settings.

Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.

Test Plan: Will test production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8727

Differential Revision: https://secure.phabricator.com/D13489

Details

Committed
epriestley <git@epriestley.com>Jun 30 2015, 20:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa8f5e10b790f: Cache remarkup engines in Feed
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1bb306348c01: Fix infinite loop in renderAccessDenied() (authored by epriestley <git@epriestley.com>).Jun 30 2015, 20:42