Homec4science

Use Drydock authorizations when acquiring leases

Authored by epriestley <git@epriestley.com> on Oct 13 2015, 02:02.

Description

Use Drydock authorizations when acquiring leases

Summary:
Ref T9519. When acquiring leases on resources:

  • Only consider resources created by authorized blueprints.
  • Only consider authorized blueprints when creating new resources.
  • Fail with a tailored error if no blueprints are allowed.
  • Fail with a tailored error if missing authorizations are causing acquisition failure.

One somewhat-substantial issue with this is that it's pretty hard to figure out from the Harbormaster side. Specifically, the Build step UI does not show field value anywhere, so the presence of unapproved blueprints is not communicated. This is much more clear in Drydock. I'll plan to address this in future changes to Harbormaster, since there are other related/similar issues anyway.

Test Plan: {F872527}

Reviewers: hach-que, chad

Reviewed By: chad

Maniphest Tasks: T9519

Differential Revision: https://secure.phabricator.com/D14254

Details

Committed
epriestley <git@epriestley.com>Oct 13 2015, 02:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdac16264e401: Update metamta for handleRequest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1bdf22535414: Use Drydock authorizations when acquiring leases (authored by epriestley <git@epriestley.com>).Oct 13 2015, 02:02