Homec4science

Implement a "Project Members" object policy rule

Authored by epriestley <git@epriestley.com> on Dec 24 2015, 01:34.

Description

Implement a "Project Members" object policy rule

Summary:
Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan:

  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Reviewers: joshuaspence, chad

Reviewed By: chad

Maniphest Tasks: T9019

Differential Revision: https://secure.phabricator.com/D14869

Details

Committed
epriestley <git@epriestley.com>Dec 24 2015, 17:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe2edb1577c0a: Improve error messages for bad hashtags and project names
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1c572d1da51f: Implement a "Project Members" object policy rule (authored by epriestley <git@epriestley.com>).Dec 24 2015, 17:16