Homec4science

Minor improvements to Applications application

Authored by epriestley <git@epriestley.com> on Jan 31 2013, 20:49.

Description

Minor improvements to Applications application

Summary:
I missed these in review, but here are a couple of tweaks:

  • Call setWorkflow(true) on the actions. This makes the dialogs pop up on the same page with Javascript if it's available.
  • When the user installs/uninstalls an application, send them back to the application's detail page, not the application list.

Test Plan:

  • Uninstalled an application (saw dialog, got sent back to detail page).
  • Installed an application (saw dialog, got sent back to detail page).
  • Canceled an application uninstall.

Reviewers: Afaque_Hussain

Reviewed By: Afaque_Hussain

CC: aran

Differential Revision: https://secure.phabricator.com/D4762

Details

Committed
epriestley <git@epriestley.com>Jan 31 2013, 20:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8b86ec6c7220: Make multiple tags render more nicely in headers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1c64b40a22b9: Minor improvements to Applications application (authored by epriestley <git@epriestley.com>).Jan 31 2013, 20:49