Homec4science

Differential - finesse Differential diff view controller

Authored by Bob Trahan <btrahan@phacility.com> on Feb 19 2015, 19:55.

Description

Differential - finesse Differential diff view controller

Summary:
Fixes T7229. Some usability issues around this controller - basically you can't leave comments with it and its not particular useful compared to the revision page.

Ergo, if there is a revision associated with a given diff, just re-direct back to the revision page with the proper diff loaded.

Test Plan: Tried to view a diff on the standalone controller attached to a revision and instead was re-directed to the revision view page with the proper diff loaded.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7229

Differential Revision: https://secure.phabricator.com/D11811

Details

Committed
Bob Trahan <btrahan@phacility.com>Feb 19 2015, 19:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf6915a797573: Add a heursitic for initial pushes which are really imports
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH1d72a5f6832d: Differential - finesse Differential diff view controller (authored by Bob Trahan <btrahan@phacility.com>).Feb 19 2015, 19:55