Homec4science

Fix overzealous subscribing in EditEngine

Authored by epriestley <git@epriestley.com> on Dec 16 2015, 01:10.

Description

Fix overzealous subscribing in EditEngine

Summary:
See T9905#148799. The CommentEditField generated empty comment transactions; these are dropped later, but before they are dropped they would trigger implicit CCs.

The implicit CC rule should probably be narrower, but we shouldn't be generating these transactions in the first place.

Test Plan: No longer implicitly CC'd on a task when doing something minor like changing projects.

Reviewers: chad

Reviewed By: chad

Subscribers: avivey

Differential Revision: https://secure.phabricator.com/D14795

Details

Committed
epriestley <git@epriestley.com>Dec 16 2015, 01:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4b3dcd550075: Add some documentation about how to set paths with owners.edit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1d72c97fc9f6: Fix overzealous subscribing in EditEngine (authored by epriestley <git@epriestley.com>).Dec 16 2015, 01:17