Homec4science

Quicksand - fix toggle behavior to work with quicksand

Authored by Bob Trahan <btrahan@phacility.com> on May 4 2015, 23:38.

Description

Quicksand - fix toggle behavior to work with quicksand

Summary:
Fixes T7919. This is a pretty generic toggle behavior. Make it quicksand ready by making it install only once and swallow the regular "click" event so the quicksand "click" event doesn't get funky with it.

Also fixes a bug in Quicksand that I discovered developing / testing this feature. We have to update the internal member variable to be better than 0 similarly to how id works. So do that.

Test Plan: went to phriction, toggled menu open, clicked home, clicked phriction and toggled menu again. Went back in history and noted menu was left to toggle state I previously had it. (currently a feature, not a bug)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7919

Differential Revision: https://secure.phabricator.com/D12708

Details

Committed
Bob Trahan <btrahan@phacility.com>May 4 2015, 23:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4ea9d76f66f1: Add some missing type hints
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH1db79044b5a2: Quicksand - fix toggle behavior to work with quicksand (authored by Bob Trahan <btrahan@phacility.com>).May 4 2015, 23:38