Homec4science

Write one DifferentialComment per CommentEditor action

Authored by epriestley <git@epriestley.com> on Feb 12 2014, 00:21.

Description

Write one DifferentialComment per CommentEditor action

Summary:
See D8200. Ref T2222. Instead of writing one comment which can have a ton of different effects, write a series of one-effect comments. These will be easier to convert into ApplicationTransactions.

This has a minor user-facing effect of making these multiple-action comments render separately:

{F111919}

Once the migration completes, they should automatically merge together nicely again.

Test Plan: Made a bunch of comments and took a bunch of actions, all of which worked normally except that they rendered as several things instead of just one.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, FacebookPOC

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8201

Details

Committed
epriestley <git@epriestley.com>Feb 12 2014, 00:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc65fad3fca0e: Separate revision updates into two separate comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1dbfc56d3588: Write one DifferentialComment per CommentEditor action (authored by epriestley <git@epriestley.com>).Feb 12 2014, 00:21