Homec4science

Modernize Conpherence access to user preferences

Authored by epriestley <git@epriestley.com> on Jun 3 2016, 16:24.

Description

Modernize Conpherence access to user preferences

Summary:
Ref T4103. Conpherence is doing some weird stuff and has its own redudnant settings object.

  • Get rid of ConpherenceSettings.
  • Use getUserSetting() instead of loadPreferences().
  • When applying transactions, add a new mechanism to efficiently prefill caches (this will still work anyway, but it's slower if we don't bulk-fetch).

Test Plan:

  • Changed global Conpherence setting.
  • Created a new Conpherence, saw setting set to global default.
  • Changed local room setting.
  • Submitted messages.
  • Saw cache prefill for all particpiants in database.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16025

Details

Committed
epriestley <git@epriestley.com>Jun 4 2016, 23:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9a076b71a3a6: Remove standalone huge single page setting edit controller
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1e17fd31a4f9: Modernize Conpherence access to user preferences (authored by epriestley <git@epriestley.com>).Jun 4 2016, 23:41