Homec4science

Fix Herald exception when updating a diff that has carryover CCs

Authored by epriestley <git@epriestley.com> on Jun 9 2011, 22:48.

Description

Fix Herald exception when updating a diff that has carryover CCs

Summary:
This is pretty subtle and tricky, but some apply transcripts don't have a rule
ID because they're purely informational. We currently get an exception, which
prevnets diff updates.

jason/tuomas: don't update phabricator.fb.com until this lands :P

Test Plan:
Applied this patch live to secure.phabricator.com and was able to update D420.

Reviewed By: gc3
Reviewers: gc3, aran, jungejason, tuomaspelkonen
CC: aran, epriestley, gc3
Differential Revision: 421

Details

Committed
epriestley <git@epriestley.com>Jun 9 2011, 23:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0ad2b526bcf4: Don't mention the same object in IRC more than once every 10 minutes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1e5fd3a3864f: Fix Herald exception when updating a diff that has carryover CCs (authored by epriestley <git@epriestley.com>).Jun 9 2011, 23:10