Homec4science

Keep setIcon() working for now on PHUIObjectItemView

Authored by epriestley <git@epriestley.com> on Aug 19 2016, 13:52.

Description

Keep setIcon() working for now on PHUIObjectItemView

Summary:
Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:

  • Config
  • Settings
  • Drydock main page
  • Almanac main page

Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.

Test Plan: Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11501

Differential Revision: https://secure.phabricator.com/D16420

Details

Committed
epriestley <git@epriestley.com>Aug 19 2016, 16:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1cca7fbccef8: Simplify PHUIObjectItemList a bit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView (authored by epriestley <git@epriestley.com>).Aug 19 2016, 16:25