Homec4science

Add a specialized cache for storing "has setup ever worked?"

Authored by epriestley <git@epriestley.com> on Sep 12 2016, 16:31.

Description

Add a specialized cache for storing "has setup ever worked?"

Summary:
Ref T11613. In D16503/T11598 I refined the setup flow to improve messaging for early-stage setup issues, but failed to fully untangle things.

We sometimes still try to access a cache which uses configuration before we build configuration, which causes an error.

Instead, store "are we in flight / has setup ever worked?" in a separate cache which doesn't use the cache namespace. This stops us from trying to read config before building config.

Test Plan:
Hit bad extension error with a fake extension, got a proper setup help page:

{F1812803}

Solved the error, reloaded, broke things again, got a "friendly" page:

{F1812805}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11613

Differential Revision: https://secure.phabricator.com/D16542

Details

Committed
epriestley <git@epriestley.com>Sep 12 2016, 17:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb822ceb6d563: Rework new favicon
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1ee426e4ac82: Add a specialized cache for storing "has setup ever worked?" (authored by epriestley <git@epriestley.com>).Sep 12 2016, 17:04