Homec4science

Don't throw an exception for partially imported commits

Authored by epriestley <git@epriestley.com> on Jan 21 2013, 16:45.

Description

Don't throw an exception for partially imported commits

Summary: Fixes T2243. We recently added the FileTreeView to Diffusion commits. However, if the page doesn't have any changesets (e.g., it has an error message instead, like "this commit hasn't imported yet"), we fail to build a file tree. In this case, don't try to build one.

Test Plan: Looked at not-imported and imported commits in Diffusion, saw proper rendering/crumbs and no exceptions.

Reviewers: btrahan, chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2243

Differential Revision: https://secure.phabricator.com/D4562

Details

Committed
epriestley <git@epriestley.com>Jan 21 2013, 16:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH660022665b73: Minor, fix example in Herald documentation.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1f7e9bcadd75: Don't throw an exception for partially imported commits (authored by epriestley <git@epriestley.com>).Jan 21 2013, 16:45