Homec4science

Stop Conpherence from reloading all messages on reply

Authored by epriestley <git@epriestley.com> on Apr 2 2013, 19:34.

Description

Stop Conpherence from reloading all messages on reply

Summary:
Currently, when you reply to a Conpherence thread, we load all the messages, not just the most recent ones. I don't think I broke this, it's just hard to tell that's what's happening unless the thread is very short or you scroll up.

The issue is that we're loading threads after some ID, but actually need to load messages (transactions) after that ID. Also, the way "before" and "after" work is sort of weird so this actually needs to be "before" (we should probably invert the meanings). Ref T2421.

Test Plan: Replied to a very short thread; saw no duplicate messages.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2421

Differential Revision: https://secure.phabricator.com/D5537

Details

Committed
epriestley <git@epriestley.com>Apr 2 2013, 19:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc13f9d157b12: Fix double-stops on profiler sampling
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1f8b237a0f4e: Stop Conpherence from reloading all messages on reply (authored by epriestley <git@epriestley.com>).Apr 2 2013, 19:34