Homec4science

Fix invalid redirect when issuing actions on buildables

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Aug 21 2014, 13:34.

Description

Fix invalid redirect when issuing actions on buildables

Summary: Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan: Restarted all builds on a buildable, saw the page reload correctly.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10320

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Aug 21 2014, 13:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb7ad48aa50f4: Minor, also update PHPMailerLite to use quoted-printable
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPH1ffa16aa6b38: Fix invalid redirect when issuing actions on buildables (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Aug 21 2014, 13:34