Homec4science

Render Remarkup in emails

Authored by Joshua Spence <josh@freelancer.com> on Nov 23 2015, 20:43.

Description

Render Remarkup in emails

Summary: Ref T992. I noticed that ManiphestTask mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I think this is because the code calls addTextSection() rather than addRemarkupSection().

Test Plan: Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with ./bin/mail show-outbound). I didn't test the other affected applications.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T992

Differential Revision: https://secure.phabricator.com/D14511

Details

Committed
Joshua Spence <josh@freelancer.com>Nov 23 2015, 20:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdf7f21b4e811: Use PHUIRemarkupPreviewView in Phame
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPH2047483cc046: Render Remarkup in emails (authored by Joshua Spence <josh@freelancer.com>).Nov 23 2015, 20:43