Homec4science

Fix two minor Differential issues

Authored by epriestley <git@epriestley.com> on Sep 18 2013, 17:57.

Description

Fix two minor Differential issues

Summary:

  • D6966 accidentally reversed the order of $diffs. Reverse it back.
  • The new policy header stuff returns array(icon, text) but gets strlen()'d by a caller. Silence that warning for now.

Test Plan: Created a revision with several diffs. Saw them in the right order; saw no warning on the diff attach screen.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran, mbishopim3

Differential Revision: https://secure.phabricator.com/D7023

Details

Committed
epriestley <git@epriestley.com>Sep 18 2013, 17:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd3de57716a4f: Add a "Header" standard custom field
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH209edcd75a93: Fix two minor Differential issues (authored by epriestley <git@epriestley.com>).Sep 18 2013, 17:57