Homec4science

Replace all instances of AphrontSideNavView with AphrontSideNavFilterView

Authored by epriestley <git@epriestley.com> on Dec 7 2012, 22:30.

Description

Replace all instances of AphrontSideNavView with AphrontSideNavFilterView

Summary:
AphrontSideNavView is an old class which required you to do a lot of work; it was obsoleted by AphrontSideNavFilterView. Remove all direct callsites so I can clean it up.

This is a precursor to letting me render a filter menu as a dropdown menu for T1960.

Test Plan:
Examined each interface for correct filter construction and selection:

  • Browsed Diffusion
  • Browsed Differential
  • Browsed Files
  • Browsed Slowvote
  • Browsed Phriction
  • Browsed repo edit interface

Grepped for AphrontSideNavView. The only remaining instances are in AphrontSideNavView itself and AphrontSideNavFilterView (which currently uses it).

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T1960

Differential Revision: https://secure.phabricator.com/D4034

Details

Committed
epriestley <git@epriestley.com>Dec 7 2012, 22:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6482876cf302: Remove the application menu
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH20ee3003b578: Replace all instances of AphrontSideNavView with AphrontSideNavFilterView (authored by epriestley <git@epriestley.com>).Dec 7 2012, 22:30