Homec4science

Fix comment previews in Quicksand

Authored by epriestley <git@epriestley.com> on Mar 28 2015, 14:54.

Description

Fix comment previews in Quicksand

Summary:
Fixes T7063. Fixes T7059. We were running some extra unnecessary behaviors. In particular, we would render the menu but not actually send it over the wire, so some behaviors would execute, fail to find the nodes they expected, and throw. This cascaded into some other failures.

Do less work and don't activate behaviors which won't be able to run.

Test Plan: Clicked around, no more errors on page transition. Comment previews work.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7059, T7063

Differential Revision: https://secure.phabricator.com/D12188

Details

Committed
epriestley <git@epriestley.com>Mar 28 2015, 14:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH637974a1903b: Polish up Done Button UI States
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH21454842bf18: Fix comment previews in Quicksand (authored by epriestley <git@epriestley.com>).Mar 28 2015, 14:54