Homec4science

Make taller tables the default for AphrontTableView

Authored by Chad Little <chad@chadsdomain.com> on Apr 8 2015, 17:38.

Description

Make taller tables the default for AphrontTableView

Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh.

Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12328

Details

Committed
Chad Little <chad@chadsdomain.com>Apr 8 2015, 17:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH13c0c3b850ea: Fix "To: Unknown Object" on outbound Maniphest mail with no owner
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@chadsdomain.com> committed rPH21f0ce736269: Make taller tables the default for AphrontTableView (authored by Chad Little <chad@chadsdomain.com>).Apr 8 2015, 17:38