Remove buildable handle / container handle logic form Harbormaster buildable…
220ac48801a1
Actions

Authored by epriestley <git@epriestley.com> on Feb 26 2016, 21:02.

Description

Remove buildable handle / container handle logic form Harbormaster buildable queries

Summary:
Ref T10457. We currently have these weird, out-of-place methods on Harbormaster queries that just load handles. These were written before HandlePool, and HandlePool is now more convenient, simpler, and more efficient.

Drop this stuff in favor of using handle pools off $viewer.

Test Plan: Looked at buildable list, looked at buildable detail, grepped for removed methods.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10457

Differential Revision: https://secure.phabricator.com/D15354

Details

Committed

epriestley <git@epriestley.com>

Feb 27 2016, 16:11

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH93b8f803a02b: Require "Can Edit" on a build plan to abort or pause associated builds

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH220ac48801a1: Remove buildable handle / container handle logic form Harbormaster buildable… (authored by epriestley <git@epriestley.com>).Feb 27 2016, 16:11

Changes (6)

				Path
	M			src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
	M			src/applications/harbormaster/interface/HarbormasterBuildableInterface.php
	M			src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php
	M			src/applications/harbormaster/query/HarbormasterBuildableQuery.php
	M			src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
	M			src/applications/harbormaster/storage/HarbormasterBuildable.php