Homec4science

Fix some small notification / token issues

Authored by epriestley <git@epriestley.com> on May 19 2013, 16:51.

Description

Fix some small notification / token issues

Summary:
Fixes T3218.

  • Currently, Paste pages don't clear notifications about the paste (notably, token notifications).
  • Currently, Paste pages don't show tooltips on tokens.
  • buildApplicationPage() stopped respecting pageObjects (which controls whether "this page has been updated" is shown). Restore that.
  • Make pageObjects imply "clear notifications on this stuff".

Test Plan: Viewed a tokened Paste. Verified it cleared the notification and hovering over a token showed a tip.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3218

Differential Revision: https://secure.phabricator.com/D5971

Details

Committed
epriestley <git@epriestley.com>May 19 2013, 16:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH94e7878a5774: Route internal conduit calls if other hosts available
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2214f96d3fef: Fix some small notification / token issues (authored by epriestley <git@epriestley.com>).May 19 2013, 16:51