Homec4science

Allow null for token expiration date

Authored by Aviv Eyal <aeyal@groupon.com> on Oct 31 2013, 01:19.

Description

Allow null for token expiration date

Summary: At least under GitHub, the token value is stored as "null", and not missing. And null > anything is false, so Phabricator thinks the token is expired or not there.

Test Plan: http://ph.vm/settings/panel/external/ before shows "No OAuth Access Token," and after it says "Active OAuth Token".

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7466

Details

Committed
epriestley <git@epriestley.com>Oct 31 2013, 01:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3a39b01233db: Add "RepositoryStatusMessage" and detailed information about initilization
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2250ee6aa6b8: Allow null for token expiration date (authored by Aviv Eyal <aeyal@groupon.com>).Oct 31 2013, 01:19