Homec4science

diffusion / differential - better handle case where no comment selected

Authored by Bob Trahan <btrahan@phacility.com> on Nov 12 2014, 21:26.

Description

diffusion / differential - better handle case where no comment selected

Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107.

Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6107

Differential Revision: https://secure.phabricator.com/D10843

Details

Committed
Bob Trahan <btrahan@phacility.com>Nov 12 2014, 21:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaeb3a12e13ae: Config - improve lock message for option `phabricator.uninstalled-applications`
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH22551d106d35: diffusion / differential - better handle case where no comment selected (authored by Bob Trahan <btrahan@phacility.com>).Nov 12 2014, 21:26