Homec4science

Fix null test plan database error

Authored by epriestley <git@epriestley.com> on Apr 11 2012, 01:54.

Description

Fix null test plan database error

Summary:
Some Differential fields are not nullable; when Test Plan is switched to non-required mode we can end up trying to save a null value to a non-nullable column (see D2193).

(I should probably just alter the schema to make these fields nullable, but that might have farther-reaching effects.)

Test Plan: Reproduced error, applied patch, no more error.

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D2200

Details

Committed
epriestley <git@epriestley.com>Apr 11 2012, 01:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH28dfeeb5d503: Make sure exceptions are surfaced from setup
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH2360504462db: Fix null test plan database error (authored by epriestley <git@epriestley.com>).Apr 11 2012, 01:54